|
I have to revert a changeset, 16464958, where a user deleted some of the objects. we have agreed on reverting the change. I see i have two options of reverting or undeleting using JOSM plugins. I want to understand what is the difference in these two. As i understand, reverter will create a new change which is opposite of the change. So i get the old object id and new version. Since it is like normal editing i also get to handle conflicts and review changes before updating. On trying to revert in JOSM, i am using the Modified object renderer to track the objects to be changed. i see that in buildings the nodes are marked to be reverted by the way is not, whereas the roads are marked to be reverted. Will be buildings be reverted or is it a bug? i have not uploaded yet. I don't know much about undelete, will it use new version or restore older version? and since it works directly with objects, do i need to restore deleted nodes of a way to restore the way? |
|
What I tend to do, if a new mapper has made a complete horlicks of something but has added some genuine new stuff that should be kept, is (after appropriate discussion with the the new mapper) to revert the original changeset but then look at the deletions in that reversion changeset and then undelete those (and fix and join as appropriate - with a new mapper a bit of tidying is to be expected). I'd tend to use Potlatch 1 or rawedit for undeletes, but "other editors are available". Re the create vs modify point, you'd expect the reversion plugin to be only doing deletes and modifies because the data either already was there and shouldn't be or already was there but was deleted. the data was there( my edits) then it was deleted (other's edit). Now i need it to be in state i left. Since it is not there now, shouldn't it be created again (maybe with new id)?
(25 Jul '13, 06:15)
amritkarma
i read the josm_file_format http://wiki.openstreetmap.org/wiki/JOSM_file_format which states that create is done by giving negaive id and does not use the action attribute.
(25 Jul '13, 10:20)
amritkarma
1
Well, "deleted" doesn't mean "gone away for ever"; it just means "marked as deleted and not currently appearing in the data". To take an example from one of my recent changesets, way 231022984 was deleted in changeset 17065699. If I was to revert that changeset, the way would be "undeleted" and appear in the data again. Using the same ID (rather than creating a new one) is much more traceable.
(25 Jul '13, 10:26)
SomeoneElse ♦
|
|
I have had trials, and i found the undelete plugin more useful. It is lengthy as we have to list out the id and type of object. I have not thoroughly tested reverter on modified object, but i suppose it works well looking at some of the instances where it was applied during this trial. As for the deleted objects, it restores the nodes, but closed ways are converted to linear feature (maybe the end node is not added). |
Please explain which tool you are talking about that offers "reverting" and "undeleting". These actions are not directly implemented in the API, so what exactly the difference is depends on which tool you are using.
(just in case future readers of this question aren't aware of it) there's an API that can be used for testing and development purposes at http://api06.dev.openstreetmap.org/ which you can use for testing the impact of whatever method it is that you're considering using.
@Frederik Ramm: Both are JOSM plugins.
@SomeoneElse: I have tried that, but it failed. maybe because there are no objects with the given ids. Deleted objects should be created, and in history browser in josm i can see negative id on them. But they fail on upload. I'll try uploading individual objects (partial revert), see if it works .
Yes - with the dev api you'll need to create test data there before you can test deleting it :)
i tried uploading individual objects in the dev server and found that JOSM is trying to modify them, instead of create. I saved the changed file before uploading and opened it in a text editor. There are objects for which actions for modify and delete are recorded but not for create.